Skip to content

Fix Tabular Annual Average Values with Unit Conversion #11410

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
mitchute wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Fix Tabular Annual Average Values with Unit Conversion #11410

mitchute wants to merge 2 commits into from
+9 −5

Conversation

@mitchute
Copy link
Collaborator

@mitchute mitchute commented Feb 3, 2026

Pull request overview

Description of the purpose of this PR

Pull Request Author

  • Title of PR should be user-synopsis style (clearly understandable in a standalone changelog context)
  • Label the PR with at least one of: Defect, Refactoring, NewFeature, Performance, and/or DoNoPublish
  • Pull requests that impact EnergyPlus code must also include unit tests to cover enhancement or defect repair
  • Author should provide a "walkthrough" of relevant code changes using a GitHub code review comment process
  • If any diffs are expected, author must demonstrate they are justified using plots and descriptions
  • If changes fix a defect, the fix should be demonstrated in plots and descriptions
  • If any defect files are updated to a more recent version, upload new versions here or on DevSupport
  • If IDD requires transition, transition source, rules, ExpandObjects, and IDFs must be updated, and add IDDChange label
  • If structural output changes, add to output rules file and add OutputChange label
  • If adding/removing any LaTeX docs or figures, update that document's CMakeLists file dependencies
  • If adding/removing any output files (e.g., eplustbl.*)
    • Update ..\scripts\Epl-run.bat
    • Update ..\scripts\RunEPlus.bat
    • Update ..\src\EPLaunch\ MainModule.bas, epl-ui.frm, and epl.vbp (VersionComments)
    • Update ...github\workflows\energyplus.py

Reviewer

  • Perform a Code Review on GitHub
  • If branch is behind develop, merge develop and build locally to check for side effects of the merge
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified
  • Check that performance is not impacted (CI Linux results include performance check)
  • Run Unit Test(s) locally
  • Check any new function arguments for performance impacts
  • Verify IDF naming conventions and styles, memos and notes and defaults
  • If new idf included, locally check the err file and other outputs

@mitchute mitchute requested a review from rraustad February 3, 2026 14:31
@mitchute mitchute self-assigned this Feb 3, 2026
@mitchute mitchute added the Defect Includes code to repair a defect in EnergyPlus label Feb 3, 2026
@mitchute
Copy link
Collaborator Author

mitchute commented Feb 3, 2026

Before and after

Screenshot from 2026-02-03 07-36-05 Screenshot from 2026-02-03 07-36-57

mitchute
mitchute commented Feb 3, 2026
View reviewed changes
Copy link
Collaborator Author

@mitchute mitchute left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Walk through

README.md

[![](https://github.com/NatLabRockies/EnergyPlus/workflows/Code%20Integrity/badge.svg)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml)
[![](https://github.com/NatLabRockies/EnergyPlus/workflows/Documentation/badge.svg)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/build_documentation.yml)
[![](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml/badge.svg?branch=develop)](https://github.com/NatLabRockies/EnergyPlus/actions/workflows/test_code_integrity.yml)
Copy link
Collaborator Author

@mitchute mitchute Feb 3, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated. Pinning the README badges to the develop branch.

src/EnergyPlus/OutputReportTabular.cc
Comment on lines +7233 to +7238
if (ort->MonthlyColumns(curCol).duration(lMonth) > 0) {
sumVal += ((ort->MonthlyColumns(curCol).reslt(lMonth) / ort->MonthlyColumns(curCol).duration(lMonth) *
curConversionFactor) +
state.dataOutRptTab->curConversionOffset) *
ort->MonthlyColumns(curCol).duration(lMonth);
}
Copy link
Collaborator Author

@mitchute mitchute Feb 3, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have to divide reslt(lMonth) by the monthly duration, convert the units, then multiply back in the monthly duration so the annual average can be calculated later.

@mitchute mitchute mentioned this pull request Feb 3, 2026
Open
@mitchute
Copy link
Collaborator Author

mitchute commented Feb 3, 2026

No diffs are shown here because CI only runs design day simulations. Running regressions without forcing DD should show diffs on PurchAirTables, PurchAirTables_wAnnual, and _SmallOffice_Dulles test files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rraustad rraustad Awaiting requested review from rraustad

Assignees

@mitchute mitchute

Labels

Defect Includes code to repair a defect in EnergyPlus

Projects

None yet

Milestone

EnergyPlus 26.1 Bug Fix Freeze

Development

Successfully merging this pull request may close these issues.

Incorrect annual average for monthly IP temperature outputs

3 participants

@mitchute @nrel-bot-2c